-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only make members required when RequiredMemberAttribute is present #68577
Conversation
src/Analyzers/CSharp/CodeFixes/MakeMemberRequired/CSharpMakeMemberRequiredCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Tests/MakeMemberRequired/MakeMemberRequiredTests.cs
Show resolved
Hide resolved
[Fact] | ||
[WorkItem("https://github.com/dotnet/roslyn/issues/68478")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Fact] | |
[WorkItem("https://github.com/dotnet/roslyn/issues/68478")] | |
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/68478")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
➡️ Keeping this one as-is
public async Task SimpleSetPropertyMissingRequiredAttribute() | ||
{ | ||
var code = | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my preference would also be consistency. but it's not a deal breaker.
Fixes #68478