Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sequence point placement in primary constructors and records #68765

Merged
merged 7 commits into from
Jul 19, 2023
Merged

Improve sequence point placement in primary constructors and records #68765

merged 7 commits into from
Jul 19, 2023
+694 −443

Conversation

tmat
Copy link
Member

@tmat tmat commented Jun 25, 2023 •
edited by jcouv
Loading

Implements changes described in #63299

Relates to test plan #40726 (records) and #65697 (primary constructors)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 25, 2023
@tmat tmat marked this pull request as ready for review June 26, 2023 20:46
@tmat tmat requested review from a team as code owners June 26, 2023 20:46
@tmat
Copy link
Member Author

tmat commented Jun 26, 2023

@RikkiGibson PTAL

@tmat
Copy link
Member Author

tmat commented Jun 26, 2023

@davidwengier PTAL

@RikkiGibson RikkiGibson self-assigned this Jun 26, 2023
RikkiGibson
RikkiGibson approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes under Compilers LGTM

src/Compilers/CSharp/Portable/Lowering/Instrumentation/DebugInfoInjector.cs Outdated Show resolved Hide resolved
src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordCopyCtor.cs Outdated Show resolved Hide resolved
src/EditorFeatures/CSharpTest/EditAndContinue/BreakpointSpansTests.cs Outdated Show resolved Hide resolved
@RikkiGibson
Copy link
Contributor

cc @jcouv @dotnet/roslyn-compiler for second review

@tmat @RikkiGibson
Update src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/Synt…
a670b35 
…hesizedRecordCopyCtor.cs

Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
@jaredpar jaredpar added this to the 17.8 milestone Jul 11, 2023
@jaredpar jaredpar removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 11, 2023
jcouv
jcouv reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass of compiler changes (iteration 5)

@jcouv jcouv self-assigned this Jul 18, 2023
jcouv
jcouv approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 7)

@tmat tmat merged commit ab1d1f1 into dotnet:main Jul 19, 2023
27 checks passed
@tmat tmat deleted the PCSequencePoints branch July 19, 2023 00:08
@ghost ghost modified the milestones: 17.8, Next Jul 19, 2023
@allisonchou allisonchou mentioned this pull request Jul 21, 2023
Closed
@tmat tmat mentioned this pull request Jul 23, 2023
Closed
@tmat tmat modified the milestones: Next, 17.8 P1 Jul 23, 2023
This was referenced Jul 24, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@RikkiGibson RikkiGibson

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
17.8 P1
Development

Successfully merging this pull request may close these issues.
5 participants
@tmat @RikkiGibson @davidwengier @jcouv @jaredpar