Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant SourceBuildTrimNetFrameworkTargets property #68772

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Remove redundant SourceBuildTrimNetFrameworkTargets property #68772

merged 2 commits into from
Jul 18, 2023

Conversation

v-chayan
Copy link
Contributor

@v-chayan v-chayan requested a review from a team as a code owner June 26, 2023 07:48
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 26, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jun 26, 2023
@v-chayan v-chayan mentioned this pull request Jun 26, 2023
Closed
@MichaelSimons
Copy link
Member

@v-chayan - can you merge in latest from tip? I would like to try and CI to pass so that I can merge this in. TIA

@MichaelSimons
Copy link
Member

@v-chayan - can you merge in latest from tip? I would like to try and CI to pass so that I can merge this in. TIA

I discovered I have access so I pulled in main.

@MichaelSimons MichaelSimons enabled auto-merge (squash) July 18, 2023 18:12
@MichaelSimons MichaelSimons merged commit 993fcc8 into dotnet:main Jul 18, 2023
27 checks passed
@ghost ghost added this to the Next milestone Jul 18, 2023
@allisonchou allisonchou mentioned this pull request Jul 21, 2023
Closed
@allisonchou allisonchou modified the milestones: Next, 17.8 P1 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@NikolaMilosavljevic NikolaMilosavljevic NikolaMilosavljevic approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P1
Development

Successfully merging this pull request may close these issues.
4 participants
@v-chayan @MichaelSimons @NikolaMilosavljevic @allisonchou