-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement simple LSP run tests #68889
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f097e9f
Enable basic unit testing support in blue
dibarbet 5c4a4bf
Merge remote-tracking branch 'upstream/main' into dev/dibarbet/unit_t…
dibarbet 50adccc
Update and simplify run tests
dibarbet fc1214e
Merge remote-tracking branch 'upstream/main' into dev/dibarbet/unit_t…
dibarbet 7a5f8f4
Review feedback
dibarbet 0de05e5
Fix formatting
dibarbet 7b730c1
Fix more formatting
dibarbet d7b6d2a
Fix vb codelens tests
dibarbet bd5b409
Review feedback
dibarbet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
src/Features/CSharp/Portable/Testing/CSharpTestMethodFinder.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System; | ||
using System.Collections.Generic; | ||
using System.Composition; | ||
using System.Linq; | ||
using Microsoft.CodeAnalysis.CSharp.Extensions; | ||
using Microsoft.CodeAnalysis.CSharp.Syntax; | ||
using Microsoft.CodeAnalysis.Features.Testing; | ||
using Microsoft.CodeAnalysis.Host.Mef; | ||
|
||
namespace Microsoft.CodeAnalysis.CSharp.Testing; | ||
|
||
[ExportLanguageService(typeof(ITestMethodFinder), LanguageNames.CSharp), Shared] | ||
[method: ImportingConstructor] | ||
[method: Obsolete(MefConstruction.ImportingConstructorMessage, error: true)] | ||
internal class CSharpTestMethodFinder([ImportMany] IEnumerable<ITestFrameworkMetadata> testFrameworks) : AbstractTestMethodFinder<MethodDeclarationSyntax>(testFrameworks) | ||
dibarbet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
protected override bool DescendIntoChildren(SyntaxNode node) | ||
{ | ||
// We only need to look in type declarations for test methods (and therefore namespaces to find types). | ||
return node is BaseNamespaceDeclarationSyntax or TypeDeclarationSyntax; | ||
} | ||
|
||
protected override bool IsTestMethod(MethodDeclarationSyntax method) | ||
{ | ||
foreach (var attributeList in method.AttributeLists) | ||
{ | ||
foreach (var attribute in attributeList.Attributes) | ||
{ | ||
var isTestAttribute = IsTestAttribute(attribute); | ||
if (isTestAttribute) | ||
{ | ||
return true; | ||
} | ||
} | ||
} | ||
|
||
return false; | ||
} | ||
|
||
private bool IsTestAttribute(AttributeSyntax attribute) | ||
{ | ||
var attributeName = attribute.Name.GetNameToken().Text; | ||
|
||
var matches = TestFrameworkMetadata.Any(metadata => metadata.MatchesAttributeSyntacticName(attributeName)); | ||
dibarbet marked this conversation as resolved.
Show resolved
Hide resolved
dibarbet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return matches; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
abstracted out because we have language specific details here.