Fix missing duplicate diagnostic for enum declarations #68967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
AlekseyTs
reviewed
Jul 11, 2023
src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 11, 2023
|
Done with review pass (commit 1) |
jcouv
reviewed
Jul 11, 2023
| // 1.cs(6,26): error CS0102: The type 'C' already contains a definition for 'D' | ||
| // public delegate void D(); | ||
| Diagnostic(ErrorCode.ERR_DuplicateNameInClass, "D").WithArguments("C", "D").WithLocation(6, 26)); | ||
| } |
There was a problem hiding this comment.
Please include the tests I documented in the issue: #67258 (comment) #Closed
There was a problem hiding this comment.
I included the one marked TODO2_2, did you also want the scenario marked TODO2 included?
There was a problem hiding this comment.
Which test did that end up being? I can't find that scenario (just a partial containing an enum, without any file-local modifier, included twice in the compilation)
There was a problem hiding this comment.
From #67258 (comment), TODO2_2 is represented by NonFileLocalEnum_Duplicate. TODO2 is not included.
|
@jcouv for a second review |
jcouv
reviewed
Jul 18, 2023
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67258