Avoid giving 'no best type' error when one of the types contains error types #68991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
333fred
approved these changes
Jul 11, 2023
333fred
approved these changes
Jul 18, 2023
jcouv
reviewed
Jul 18, 2023
|
|
||
| public class C { | ||
| public void M0() { | ||
| Func<bool, int> fn1 = flag => |
There was a problem hiding this comment.
Could you also include a lambda scenario without target-type (ie. var fn = ...)? #Closed
jcouv
reviewed
Jul 18, 2023
| Diagnostic(ErrorCode.ERR_ImplicitlyTypedArrayNoBestType, "new[] { x1, y1 }").WithLocation(5, 18), | ||
| // (7,18): error CS0826: No best type found for implicitly-typed array | ||
| Diagnostic(ErrorCode.ERR_NoImplicitConv, "x1").WithArguments("C", "Unknown?").WithLocation(5, 26), | ||
| // 0.cs(7,30): error CS0029: Cannot implicitly convert type 'C' to 'Unknown?' |
There was a problem hiding this comment.
Not blocking this PR: should we also prevent this cascading diagnostic?
There was a problem hiding this comment.
I think that's a good idea. Opening #69138.
jcouv
approved these changes
Jul 18, 2023
jcouv
removed
the
untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67751
Moving to draft while I build out the test coverage.