Consolidate Interlocked initialize implementations #69017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
This comment was marked as resolved.
This comment was marked as resolved.
sharwell
changed the title
Initialization calls where the initialized value is null and the uninitialized value is non-null became ambiguous once additional initialization patterns were implemented. Since this is only used in one situation in each of C# and VB compilers, we resolve it by providing an explicit argument name for the initialized value.
jaredpar
approved these changes
Jul 13, 2023
|
@dotnet/roslyn-compiler for second review |
1 similar comment
|
@dotnet/roslyn-compiler for second review |
RikkiGibson
reviewed
Jul 19, 2023
| @@ -1549,7 +1549,7 @@ internal override ObsoleteAttributeData ObsoleteAttributeData | |||
| { | |||
| var result = uncommonFields._lazyObsoleteAttributeData; | |||
| return ReferenceEquals(result, ObsoleteAttributeData.Uninitialized) | |||
| ? InterlockedOperations.Initialize(ref uncommonFields._lazyObsoleteAttributeData, null, ObsoleteAttributeData.Uninitialized) | |||
| ? InterlockedOperations.Initialize(ref uncommonFields._lazyObsoleteAttributeData, initializedValue: null, ObsoleteAttributeData.Uninitialized) | |||
There was a problem hiding this comment.
I couldn't find any overlap/conflict
There was a problem hiding this comment.
I think there actually isn't any. I think the linked PR is using Interlocked.CompareExchange, not any InterlockedOperations or similar APIs that changed in this PR.
RikkiGibson
approved these changes
Jul 19, 2023
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LazyInitializationintoInterlockedOperations(RoslynLazyInitializerwas not appropriate as that type is a mirror ofLazyInitializerfor nullable reference types support)Initialize) and clarity (helper method namedGetOrStore)