Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve EnC analysis to handle active statements in primary constructors #69028

Merged
merged 6 commits into from
Jul 20, 2023
Merged

Improve EnC analysis to handle active statements in primary constructors #69028

merged 6 commits into from
Jul 20, 2023

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 13, 2023 •
edited
Loading

Completes #67108

  • Adds DeclarationBody subclasses to represet properties, accessors, primary constructors, copy constructors and record parameters.
  • Simplify marked source handling in EnC tests and allow tags for multiple active statements start at the same offset and allow zero-width active statement spans.
  • A lot of small simplifications in the EnC analyzer

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 13, 2023
@tmat tmat force-pushed the PCActiveStatements branch 3 times, most recently from 68409c1 to 80a6081 Compare July 18, 2023 02:11
@tmat tmat changed the title Pc active statements Improve EnC analysis to handle active statements in primary constructors Jul 19, 2023
@tmat tmat marked this pull request as ready for review July 19, 2023 00:25
@tmat tmat requested a review from a team as a code owner July 19, 2023 00:25
@tmat
Copy link
Member Author

tmat commented Jul 19, 2023

@davidwengier PTAL

@tmat tmat enabled auto-merge (squash) July 20, 2023 19:21
@tmat tmat merged commit 5f72455 into dotnet:main Jul 20, 2023
24 checks passed
@ghost ghost added this to the Next milestone Jul 20, 2023
@allisonchou allisonchou mentioned this pull request Jul 21, 2023
Closed
@tmat tmat mentioned this pull request Jul 24, 2023
Merged
@allisonchou allisonchou modified the milestones: Next, 17.8 P1 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @davidwengier @allisonchou