Update 'initialize member from parameter' to work with primary constructors. #69072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jul 17, 2023
| @@ -56,55 +56,10 @@ protected override SyntaxNode GetBody(SyntaxNode functionDeclaration) | |||
| => InitializeParameterHelpers.GetBody(functionDeclaration); | |||
|
|
|||
| protected override SyntaxNode? GetAccessorBody(IMethodSymbol accessor, CancellationToken cancellationToken) | |||
| { | |||
There was a problem hiding this comment.
moved to common helper locations.
CyrusNajmabadi
commented
Jul 17, 2023
| @@ -314,19 +316,6 @@ internal abstract partial class AbstractInitializeMemberFromParameterCodeRefacto | |||
| throw ExceptionUtilities.Unreachable(); | |||
| } | |||
|
|
|||
| private static string GenerateUniqueName(IParameterSymbol parameter, ImmutableArray<string> parameterNameParts, NamingRule rule) | |||
There was a problem hiding this comment.
moved to common helper location.
There was a problem hiding this comment.
same with the other deletions in the file
CyrusNajmabadi
commented
Jul 17, 2023
| { | ||
| internal static class InitializeParameterHelpersCore | ||
| { | ||
| public static ImmutableArray<(IParameterSymbol parameter, bool before)> GetSiblingParameters(IParameterSymbol parameter) |
There was a problem hiding this comment.
these are just moves of helpers.
CyrusNajmabadi
commented
Jul 17, 2023
| @@ -138,5 +142,86 @@ public static bool IsExpressionBody(SyntaxNode body) | |||
| _ => throw ExceptionUtilities.UnexpectedValue(body), | |||
| }; | |||
| } | |||
|
|
|||
| public static SyntaxNode? GetAccessorBody(IMethodSymbol accessor, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
these are just moves of helpers.
sharwell
reviewed
Jul 17, 2023
...izeParameter/CSharpInitializeMemberFromPrimaryConstructorParameterCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Jul 17, 2023
...izeParameter/CSharpInitializeMemberFromPrimaryConstructorParameterCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Jul 18, 2023
| var outParameters = parameterList.Parameters | ||
| .Select(p => semanticModel.GetRequiredDeclaredSymbol(p, cancellationToken)) | ||
| .Where(p => p.RefKind == RefKind.Out) | ||
| .ToImmutableArray(); |
There was a problem hiding this comment.
cast removed as this now uses a typesafe extension.
akhera99
approved these changes
Jul 18, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68817
Looks like this:
QOL for people using primary constructors. Just like witha normal constructor, we want to make it easy to be writing the constructor and then have the user go and create fields/props easily.
Fixes #68817