Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tracking link to issue 44902 #69095

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Remove tracking link to issue 44902 #69095

merged 1 commit into from
Jul 21, 2023

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Jul 18, 2023

No description provided.

@jcouv jcouv self-assigned this Jul 18, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 18, 2023
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 18, 2023
@jcouv jcouv marked this pull request as ready for review July 20, 2023 23:29
@jcouv jcouv requested a review from a team as a code owner July 20, 2023 23:29
@@ -37,7 +37,6 @@ internal sealed class SynthesizedRecordCopyCtor : SynthesizedInstanceConstructor

internal override void GenerateMethodBodyStatements(SyntheticBoundNodeFactory F, ArrayBuilder<BoundStatement> statements, BindingDiagnosticBag diagnostics)
{
// Tracking issue for copy constructor in inheritance scenario: https://github.com/dotnet/roslyn/issues/44902
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this issue tracking, and has that been resolved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was tracking how the copy constructor should work (should delegate to base copy ctor, except for object, and should not include initializers). The issue was closed as completed: #44902

@jcouv jcouv merged commit d974dd1 into dotnet:main Jul 21, 2023
25 checks passed
@jcouv jcouv deleted the remove-link branch July 21, 2023 03:32
@ghost ghost added this to the Next milestone Jul 21, 2023
@allisonchou allisonchou modified the milestones: Next, 17.8 P1 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants