Don't create a .exe when building platform neutral language server bits #69110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
approved these changes
Jul 19, 2023
| @@ -1,6 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <UseAppHost Condition="'$(RuntimeIdentifier)' == ''">false</UseAppHost> | |||
There was a problem hiding this comment.
This might deserve a comment to explain a bit more. Is this a temporary workaround or really how it should work?
There was a problem hiding this comment.
Not a temporary workaround. If we're not building and publishing for a specific runtime identifier, we should be producing platform neutral bits, which they are generally. However by default since we have an outputtype of exe and we're building on windows, it also produces a .exe which we don't need.
Solution is to tell it not to create an exe if we're not building for a specific runtime identifier. I'll put a comment to this effect in the code
arunchndr
approved these changes
Jul 19, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fully work, this needs changes on the client to automatically detect no executable is present (working on it now). However the neutral version is broken anyway (it can't find the appropriate executable on linux)
Property docs - https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#useapphost