Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: add empty commands array to ServerCapabilites.ExecuteCommandProvider #69128

Merged
merged 1 commit into from
Jul 20, 2023
Merged

LSP: add empty commands array to ServerCapabilites.ExecuteCommandProvider #69128

merged 1 commit into from
Jul 20, 2023

Conversation

jdrst
Copy link
Contributor

@jdrst jdrst commented Jul 20, 2023

fixes #68849

@jdrst jdrst requested a review from a team as a code owner July 20, 2023 13:19
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jul 20, 2023
dibarbet
dibarbet approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@dibarbet dibarbet merged commit 6710402 into dotnet:main Jul 20, 2023
24 checks passed
@ghost ghost added this to the Next milestone Jul 20, 2023
@allisonchou allisonchou mentioned this pull request Jul 21, 2023
Closed
@allisonchou allisonchou modified the milestones: Next, 17.8 P1 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.8 P1
Development

Successfully merging this pull request may close these issues.

Microsoft.CodeAnalysis.LanguageServer is not reporting capabilities according to lsp-spec.
3 participants
@jdrst @dibarbet @allisonchou