Avoid array enumerator allocations in SimpleDiagnostic.Equals #69238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 88GB allocations observed in an 80 second performance trace for the VS testing team.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
CyrusNajmabadi
approved these changes
Jul 26, 2023
|
@dotnet/roslyn-compiler for reviews |
cston
reviewed
Jul 26, 2023
| @@ -153,6 +153,29 @@ internal static int BinarySearch(this int[] array, int value) | |||
| return ~low; | |||
| } | |||
|
|
|||
| public static bool SequenceEqual<T>(this T[]? first, T[]? second, Func<T, T, bool> comparer) | |||
| { | |||
| RoslynDebug.Assert(comparer != null); | |||
There was a problem hiding this comment.
➡️ RoslynDebug.Assert is the null-annotated form of this invocation.
cston
approved these changes
Jul 26, 2023
jjonescz
approved these changes
Jul 27, 2023
333fred
approved these changes
Jul 27, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 88GB allocations observed in an 80 second performance trace for the VS testing team. The allocations originated from this line:
roslyn/src/Compilers/Core/Portable/Diagnostic/Diagnostic_SimpleDiagnostic.cs
Line 165 in d0c8767