Allow Razor to format a new document it wants to create #69878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
This was referenced Sep 11, 2023
3 tasks
|
Ping @dotnet/razor-tooling @dotnet/roslyn-ide for reviews if you please |
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/FormatNewFileHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/FormatNewFileHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/FormatNewFileParams.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/FormatNewFileParams.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Sep 14, 2023
ghost
added this to the
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Sep 14, 2023
Fixes #4330 Fixes #8766 Includes #9262 so just review from 8a2b8af onwards Goes with dotnet/roslyn#69878 and dotnet/vscode-csharp#6329 I logged #9264 to follow up with a better test, though strictly speaking the one I've added id exhaustive :) Behaviour of Extract to Code Behind before this change. Note the many using statements and block scoped namespace.  Behaviour after this change. Note the file scoped namespace, and file header.  The squiggle on `NavigationManager` is due to an `.editorconfig` rule I have on in that project, requiring `this.` qualification, so is unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/razor#4330
Goes with dotnet/razor#9263 and dotnet/vscode-csharp#6329
Adds a custom endpoint so Razor can get access to the
INewDocumentFormattingService, as well as remove and sort usings, and format the new document with the current C# format options.