Use vs-threading extensions where available #69932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sharwell
commented
Sep 13, 2023
sharwell
commented
- Avoid throwing cancellation exceptions (follow-up to Avoid cancellation exceptions in async queue implementation #68412)
- Use provided NoThrowAwaitable extension method
* Avoid throwing cancellation exceptions (follow-up to dotnet#68412) * Use provided NoThrowAwaitable extension method
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -307,11 +307,11 @@ static async Task WaitForHighPriorityTasksAsync(CancellationToken cancellationTo | |||
| if (task.IsCompleted) | |||
| { | |||
| // Make sure to yield so continuations of 'task' can make progress. | |||
| await Task.Yield().ConfigureAwait(false); | |||
| await AwaitExtensions.ConfigureAwait(Task.Yield(), false); | |||
There was a problem hiding this comment.
curious why it needs to be called in extension form.
There was a problem hiding this comment.
➡️ Roslyn has the same extension defined in Roslyn.Utilities, and unlike how we handled NoThrowAwaitable it wasn't renamed to ConfigureAwaitInternal.
There was a problem hiding this comment.
can we remove that though, and just use the new extension instead? (this can all come in a later PR of coursE).
There was a problem hiding this comment.
➡️ Not trivially. It could be renamed, but this was the only potential conflict location. There are several references in workspaces/features where the conflict can't occur.
CyrusNajmabadi
approved these changes
Sep 13, 2023
sharwell
commented
Sep 13, 2023
| await _dataSource.ThreadingContext.JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); | ||
| #pragma warning disable VSTHRD004 // Await SwitchToMainThreadAsync | ||
| await _dataSource.ThreadingContext.JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken).NoThrowAwaitable(); | ||
| #pragma warning restore VSTHRD004 // Await SwitchToMainThreadAsync |
There was a problem hiding this comment.
False positive reported as microsoft/vs-threading#1232
3 tasks
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.