-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new endpoint in roslyn to get token for multiple ranges #69946
Merged
ToddGrun
merged 22 commits into
dotnet:main
from
maryamariyan:dev/maryamariyan/ranges-endpoint
Sep 20, 2023
Merged
Add new endpoint in roslyn to get token for multiple ranges #69946
ToddGrun
merged 22 commits into
dotnet:main
from
maryamariyan:dev/maryamariyan/ranges-endpoint
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
Sep 14, 2023
ghost
added
the
Community
The pull request was submitted by a contributor who is not a Microsoft employee.
label
Sep 14, 2023
maryamariyan
commented
Sep 14, 2023
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/SemanticTokensRangesHandler.cs
Outdated
Show resolved
Hide resolved
maryamariyan
commented
Sep 14, 2023
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/SemanticTokensRangesHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/ProtocolUnitTests/SemanticTokens/SemanticTokensRangesTests.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/SemanticTokensRangesHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/SemanticTokensRangesHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/SemanticTokensRangesHandler.cs
Outdated
Show resolved
Hide resolved
✘ Microsoft.CodeAnalysis.LanguageServer.UnitTests.SemanticTokens.SemanticTokensRangesTests.TestGetSemanticTokensRanges_FullDocAsync(mutatingLspWorkspace: False, isVS: True)
174ms
Error:
StreamJsonRpc.RemoteMethodNotFoundException : No method by the name 'textDocument/semanticTokens/ranges' is found. Stack trace: at StreamJsonRpc.JsonRpc.<InvokeCoreAsync>d__151`1.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult() at Roslyn.Test.Utilities.AbstractLanguageServerProtocolTests.TestLspServer.<ExecuteRequestAsync>d__13`2.MoveNext() in C:\CodeHub\roslyn\src\EditorFeatures\TestUtilities\LanguageServer\AbstractLanguageServerProtocolTests.cs:line 640 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() at Microsoft.CodeAnalysis.LanguageServer.UnitTests.SemanticTokens.AbstractSemanticTokensTests.<RunGetSemanticTokensAsync>d__2.MoveNext() in C:\CodeHub\roslyn\src\Features\LanguageServer\ProtocolUnitTests\SemanticTokens\AbstractSemanticTokensTests.cs:line 45 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() at Microsoft.CodeAnalysis.LanguageServer.UnitTests.SemanticTokens.SemanticTokensRangesTests.<TestGetSemanticTokensRanges_FullDocAsync>d__1.MoveNext() in C:\CodeHub\roslyn\src\Features\LanguageServer\ProtocolUnitTests\SemanticTokens\SemanticTokensRangesTests.cs:line 37 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at Microsoft.CodeAnalysis.LanguageServer.UnitTests.SemanticTokens.SemanticTokensRangesTests.<TestGetSemanticTokensRanges_FullDocAsync>d__1.MoveNext() in C:\CodeHub\roslyn\src\Features\LanguageServer\ProtocolUnitTests\SemanticTokens\SemanticTokensRangesTests.cs:line 69 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) |
…es-endpoint Conflicts: src/EditorFeatures/Core/LanguageServer/RazorInProcLanguageClient.cs
maryamariyan
commented
Sep 14, 2023
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/SemanticTokensRangesHandler.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Sep 14, 2023
src/Features/LanguageServer/Protocol/ExternalAccess/Razor/SemanticTokensRangesHandler.cs
Outdated
Show resolved
Hide resolved
This was referenced Sep 14, 2023
Closed
Closed
Closed
3 tasks
|
ToddGrun
reviewed
Sep 15, 2023
src/Features/LanguageServer/Protocol/Handler/SemanticTokens/SemanticTokensHelpers.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Sep 15, 2023
src/Features/LanguageServer/Protocol/Handler/SemanticTokens/SemanticTokensHelpers.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Sep 15, 2023
src/Features/LanguageServer/ProtocolUnitTests/SemanticTokens/SemanticTokensRangeTests.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Sep 15, 2023
src/Features/LanguageServer/Protocol/Handler/SemanticTokens/SemanticTokensHelpers.cs
Outdated
Show resolved
Hide resolved
Since queue is not a service that mef can import in a standard way
ToddGrun
reviewed
Sep 18, 2023
src/Features/LanguageServer/ProtocolUnitTests/SemanticTokens/SemanticTokensRangeTests.cs
Outdated
Show resolved
Hide resolved
(using custom endpoint for now) - Unit test fix: (Endpoint should implement ILspServiceDocumentRequestHandler not ILspServiceRequestHandler)
dibarbet
approved these changes
Sep 18, 2023
src/Features/LanguageServer/ProtocolUnitTests/SemanticTokens/AbstractSemanticTokensTests.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Sep 19, 2023
src/Features/LanguageServer/Protocol/Handler/SemanticTokens/SemanticTokensHelpers.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Sep 19, 2023
src/Features/LanguageServer/Protocol/Handler/SemanticTokens/SemanticTokensHelpers.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Sep 19, 2023
src/Features/LanguageServer/Protocol/Handler/SemanticTokens/SemanticTokensHelpers.cs
Outdated
Show resolved
Hide resolved
ToddGrun
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to: dotnet/razor#9273