Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Primary Constructor tests for some scenarios from Test Plan #70026

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested a review from a team as a code owner September 19, 2023 22:15
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 19, 2023
// primary constructor parameter, even in field initializers and base clause arguments, we already
// have pre-existing behavior with records that is not consistent with that. Specifically, primary constructor
// parameters come first in field initializers and base clause arguments for records.
// Keeping this behavior for now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worth mentioning this in the speclet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worth mentioning this in the speclet?

I am going to bring this as an open design question to LDM.

…rTests.cs

Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
@AlekseyTs AlekseyTs merged commit 8b35705 into dotnet:main Sep 20, 2023
25 checks passed
@ghost ghost added this to the Next milestone Sep 20, 2023
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Feature - Primary Constructors untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants