Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Primary Constructor tests for some scenarios from Test Plan #70056

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Add Primary Constructor tests for some scenarios from Test Plan #70056

merged 1 commit into from
Sep 28, 2023

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested review from jjonescz, cston and a team September 21, 2023 14:24
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 21, 2023
@jcouv jcouv added the Test Test failures in roslyn-CI label Sep 25, 2023
jcouv
jcouv approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Sep 25, 2023
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 25, 2023
@AlekseyTs AlekseyTs merged commit c3ab47a into dotnet:main Sep 28, 2023
25 checks passed
@ghost ghost added this to the Next milestone Sep 28, 2023
@AlekseyTs AlekseyTs mentioned this pull request Sep 21, 2023
Closed
@allisonchou allisonchou mentioned this pull request Oct 10, 2023
Closed
@jjonescz jjonescz modified the milestones: Next, 17.9 P1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@jjonescz jjonescz jjonescz approved these changes

@cston cston Awaiting requested review from cston

Assignees

@jcouv jcouv

Labels
Area-Compilers Feature - Primary Constructors Test Test failures in roslyn-CI
Projects
None yet
Milestone
17.9 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekseyTs @jjonescz @jcouv