Fix build race #70261
Merged
Fix build race #70261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
3 tasks
We were accidentally creating a number of duplicate builds for a few reasons: - When we invoked the build for the BuildHost, that set RuntimeIdentifer= which had the effect of meaning MSBuild did not consider that to be the same build as a "regular" build that sets just the TFM. By setting RemoveProperties instead of that property, we can unify builds better. - When we are packing each RID separately, that was also triggering parallel builds of the other projects since each build was also passing PackRuntimeIdentifier to the dependencies of the language server. But that property doesn't impact anything there, so that's unnecessary and just creates additional races.
jasonmalinowski
force-pushed
the
fix-build-race
branch
from
4691b2e to
b517dbf
Compare
rainersigwald
approved these changes
Oct 11, 2023
dibarbet
reviewed
Oct 11, 2023
| which causes a lot of duplicate building. This removes it. --> | ||
| <ItemDefinitionGroup> | ||
| <ProjectReference> | ||
| <GlobalPropertiesToRemove>PackRuntimeIdentifier</GlobalPropertiesToRemove> |
There was a problem hiding this comment.
I don't really know what is going on here. If you can verify that all the dependency dlls are R2R images in the pack output I'm good.
dibarbet
approved these changes
Oct 11, 2023
Without specifically looking for items under an ItemGroup, it was tripped up by ItemDefinitionGroups.
jaredpar
approved these changes
Oct 11, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting RuntimeIdentifier= we were preventing MSBuild from only running that once, since the regular invocation of the build would set the TFM but not the RID. This doesn't seem necessary anymore, so we can just remove it.