Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend void keyword in using unsafe directives #70289

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Recommend void keyword in using unsafe directives #70289

merged 4 commits into from
Oct 12, 2023

Conversation

jhinder
Copy link
Contributor

@jhinder jhinder commented Oct 8, 2023

Fixes #67986.

@jhinder jhinder requested a review from a team as a code owner October 8, 2023 13:12
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Oct 8, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 8, 2023
CyrusNajmabadi
CyrusNajmabadi approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CyrusNajmabadi
CyrusNajmabadi approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DoctorKrolic
Copy link
Contributor

Something is really broken here:
firefox_5OcfGMbAUq

@CyrusNajmabadi
Copy link
Member

@DoctorKrolic that means the branch is on lockdown.

@DoctorKrolic
Copy link
Contributor

Auto-merge seems to be broken...

@CyrusNajmabadi
Copy link
Member

@DoctorKrolic yup. if the branch was locked down, merging/auto-merging has to be done manually after it opens. Thanks for the contribution!

@CyrusNajmabadi CyrusNajmabadi merged commit 1895182 into dotnet:main Oct 12, 2023
24 checks passed
@ghost ghost added this to the Next milestone Oct 12, 2023
@jhinder jhinder deleted the void-in-using-unsafe branch October 13, 2023 14:11
@allisonchou allisonchou mentioned this pull request Oct 13, 2023
Closed
@jjonescz jjonescz modified the milestones: Next, 17.9 P1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.9 P1
Development

Successfully merging this pull request may close these issues.

void keyword not recommended in "using unsafe" directive
4 participants
@jhinder @DoctorKrolic @CyrusNajmabadi @jjonescz