In most cases, remove the camel case matching for case sensitive matches #70324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hes. There is no need to do this unless the pattern is successfully matched case insensitively. Prism has marked several PatternMatcher calls under TryCamelCaseMatch when looking at CPU stacks for the completion scenario.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Oct 10, 2023
|
Prism bug: AB#1899339 |
sharwell
approved these changes
Oct 11, 2023
| @@ -446,20 +445,21 @@ private bool PartStartsWith(string candidate, TextSpan candidatePart, string pat | |||
| // i.e. CoFiPro would match CodeFixProvider, but CofiPro would not. | |||
| if (patternChunk.PatternHumps.Count > 0) | |||
| { | |||
| var camelCaseKind = TryUpperCaseCamelCaseMatch(candidate, candidateHumps, patternChunk, CompareOptions.None, out var matchedSpans); | |||
| if (camelCaseKind.HasValue) | |||
| // No need to do the case sensitive check unless the case insensitive check is successful | |||
There was a problem hiding this comment.
as per our offline convo, it might be nice to have a little more verbosity explaining why this is good.
namely that the expected case is to test the pattern matcher against thousands of items, with only a handful matching. As such, the existing approach takes 2x checks against all those thousands of items. Whereas the new approach does (1x + handful) checks.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to do this unless the pattern is successfully matched case insensitively. Prism has marked several PatternMatcher calls under TryCamelCaseMatch when looking at CPU stacks for the completion scenario.