Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection expressions - error when we can't emit good codegen for ImmutableArray #70384

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Collection expressions - error when we can't emit good codegen for ImmutableArray #70384

merged 2 commits into from
Oct 16, 2023

Conversation

RikkiGibson
Copy link
Contributor

Closes #70351
Closes #69136

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 13, 2023
@RikkiGibson RikkiGibson marked this pull request as ready for review October 16, 2023 19:54
@RikkiGibson RikkiGibson requested a review from a team as a code owner October 16, 2023 19:54
cston
cston reviewed Oct 16, 2023
View reviewed changes
src/Compilers/CSharp/Test/Emit2/Semantics/CollectionExpressionTests.cs
IL_0021: ret
}
""");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

Consider adding a test for the non-generic IEnumerable case, perhaps by compiling with TargetFramework.Mscorlib40 and

namespace System.Collections.Immutable
{
    struct ImmutableArray<T> : IEnumerable
    {
        public void Add(T t) { }
        IEnumerator IEnumerable.GetEnumerator() => null;
    }
}

@RikkiGibson RikkiGibson merged commit 6a1b2d7 into dotnet:main Oct 16, 2023
25 checks passed
@RikkiGibson RikkiGibson deleted the immutablearray-downlevel branch October 16, 2023 22:32
@ghost ghost added this to the Next milestone Oct 16, 2023
RikkiGibson added a commit to RikkiGibson/roslyn that referenced this pull request Oct 17, 2023
@RikkiGibson
Collection expressions - error when we can't emit good codegen for Im…
b06244c 
…mutableArray (dotnet#70384)
@RikkiGibson RikkiGibson mentioned this pull request Oct 17, 2023
Merged
@allisonchou allisonchou mentioned this pull request Oct 18, 2023
Closed
@jjonescz jjonescz modified the milestones: Next, 17.9 P1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.9 P1
4 participants
@RikkiGibson @333fred @cston @jjonescz