Merge main to ParamsCollections

.devcontainer/Dockerfile

@@ -1,8 +1,6 @@
 # See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.192.0/containers/dotnet/.devcontainer/base.Dockerfile
 
-# [Choice] .NET version: 6.0, 5.0, 3.1, 2.1
-ARG VARIANT="6.0"
-FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-${VARIANT}
+FROM mcr.microsoft.com/vscode/devcontainers/dotnet:8.0
 
 # Set up machine requirements to build the repo
 RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \

.devcontainer/devcontainer.json

@@ -1,56 +1,59 @@
 // For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
 // https://github.com/microsoft/vscode-dev-containers/tree/v0.140.1/containers/dotnetcore
 {
-  "name": "C# (.NET 6)",
+  "name": "C# (.NET 8)",
   "build": {
     "dockerfile": "Dockerfile",
-    "args": {
-      "VARIANT": "6.0",
-    }
   },
-  "settings": {
-    "files.associations": {
-      "*.csproj": "msbuild",
-      "*.fsproj": "msbuild",
-      "*.globalconfig": "ini",
-      "*.manifest": "xml",
-      "*.nuspec": "xml",
-      "*.pkgdef": "ini",
-      "*.projitems": "msbuild",
-      "*.props": "msbuild",
-      "*.resx": "xml",
-      "*.rsp": "Powershell",
-      "*.ruleset": "xml",
-      "*.settings": "xml",
-      "*.shproj": "msbuild",
-      "*.slnf": "json",
-      "*.targets": "msbuild",
-      "*.vbproj": "msbuild",
-      "*.vsixmanifest": "xml",
-      "*.vstemplate": "xml",
-      "*.xlf": "xml",
-      "*.yml": "azure-pipelines"
-    },
-    // ms-dotnettools.csharp settings
-    "omnisharp.defaultLaunchSolution": "Roslyn.sln",
-    "omnisharp.disableMSBuildDiagnosticWarning": true,
-    "omnisharp.enableEditorConfigSupport": true,
-    "omnisharp.enableImportCompletion": true,
-    "omnisharp.useModernNet": true,
-    "omnisharp.enableAsyncCompletion": true,
-    // ms-vscode.powershell settings
-    "powershell.promptToUpdatePowerShell": false,
-    "powershell.integratedConsole.showOnStartup": false,
-    "powershell.startAutomatically": false,
-    // ms-azure-devops.azure-pipelines settings
-    "azure-pipelines.customSchemaFile": ".vscode/dnceng-schema.json"
+  "customizations": {
+    "vscode": {
+      "settings": {
+        "files.associations": {
+          "*.csproj": "msbuild",
+          "*.fsproj": "msbuild",
+          "*.globalconfig": "ini",
+          "*.manifest": "xml",
+          "*.nuspec": "xml",
+          "*.pkgdef": "ini",
+          "*.projitems": "msbuild",
+          "*.props": "msbuild",
+          "*.resx": "xml",
+          "*.rsp": "Powershell",
+          "*.ruleset": "xml",
+          "*.settings": "xml",
+          "*.shproj": "msbuild",
+          "*.slnf": "json",
+          "*.targets": "msbuild",
+          "*.vbproj": "msbuild",
+          "*.vsixmanifest": "xml",
+          "*.vstemplate": "xml",
+          "*.xlf": "xml",
+          "*.yml": "azure-pipelines"
+        },
+        // ms-dotnettools.csharp settings
+        "omnisharp.disableMSBuildDiagnosticWarning": true,
+        "omnisharp.enableEditorConfigSupport": true,
+        "omnisharp.enableImportCompletion": true,
+        "omnisharp.useModernNet": true,
+        "omnisharp.enableAsyncCompletion": true,
+        // ms-dotnettools.csdevkit settings
+        "dotnet.defaultSolution": "Roslyn.sln",
+        // ms-vscode.powershell settings
+        "powershell.promptToUpdatePowerShell": false,
+        "powershell.integratedConsole.showOnStartup": false,
+        "powershell.startAutomatically": false,
+        // ms-azure-devops.azure-pipelines settings
+        "azure-pipelines.customSchemaFile": ".vscode/dnceng-schema.json"
+      },
+      "extensions": [
+        "ms-dotnettools.csharp",
+        "ms-dotnettools.csdevkit",
+        "EditorConfig.EditorConfig",
+        "ms-vscode.powershell",
+        "tintoy.msbuild-project-tools",
+        "ms-azure-devops.azure-pipelines"
+      ]
+    }
   },
-  "extensions": [
-    "ms-dotnettools.csharp",
-    "EditorConfig.EditorConfig",
-    "ms-vscode.powershell",
-    "tintoy.msbuild-project-tools",
-    "ms-azure-devops.azure-pipelines"
-  ],
   "postCreateCommand": "${containerWorkspaceFolder}/restore.sh"
 }

docs/Language Feature Status.md

@@ -10,12 +10,14 @@ efforts behind them.
 
 | Feature | Branch | State | Developer | Reviewer | IDE Buddy | LDM Champ |
 | ------- | ------ | ----- | --------- | -------- | --------- | --------- |
+| [Params-collections](https://github.com/dotnet/csharplang/issues/7700) | [ParamsCollections](https://github.com/dotnet/roslyn/tree/features/ParamsCollections) | [In Progress](https://github.com/dotnet/roslyn/issues/71137) | [AlekseyTs](https://github.com/AlekseyTs) | [RikkiGibson](https://github.com/RikkiGibson), [333fred](https://github.com/333fred) |  |  [MadsTorgersen](https://github.com/MadsTorgersen), [AlekseyTs](https://github.com/AlekseyTs) |
 | [Semi-auto-properties](https://github.com/dotnet/csharplang/issues/140) | [semi-auto-props](https://github.com/dotnet/roslyn/tree/features/semi-auto-props) | [In Progress](https://github.com/dotnet/roslyn/issues/57012) | [Youssef1313](https://github.com/Youssef1313) | [333fred](https://github.com/333fred), [RikkiGibson](https://github.com/RikkiGibson) |  | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) |
 | [Params Span\<T> + Stackalloc any array type](https://github.com/dotnet/csharplang/issues/1757) | [params-span](https://github.com/dotnet/roslyn/tree/features/params-span) | [In Progress](https://github.com/dotnet/roslyn/issues/57049) | [cston](https://github.com/cston) | TBD |  | [jaredpar](https://github.com/jaredpar) |
 | [Default in deconstruction](https://github.com/dotnet/roslyn/pull/25562) | [decon-default](https://github.com/dotnet/roslyn/tree/features/decon-default) | [In Progress](https://github.com/dotnet/roslyn/issues/25559) | [jcouv](https://github.com/jcouv) | [gafter](https://github.com/gafter) |  | [jcouv](https://github.com/jcouv) |
 | [Roles/Extensions](https://github.com/dotnet/csharplang/issues/5497) | [roles](https://github.com/dotnet/roslyn/tree/features/roles) | [In Progress](https://github.com/dotnet/roslyn/issues/66722) | [jcouv](https://github.com/jcouv) | [AlekseyTs](https://github.com/AlekseyTs), [jjonescz](https://github.com/jjonescz) |  | [MadsTorgersen](https://github.com/MadsTorgersen) |
 | [Escape character](https://github.com/dotnet/csharplang/issues/7400) | N/A | [In Progress](https://github.com/dotnet/roslyn/pull/70497) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [jcouv](https://github.com/jcouv), [RikkiGibson](https://github.com/RikkiGibson) |  | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | 
 | [Method group natural type improvements](https://github.com/dotnet/csharplang/blob/main/proposals/method-group-natural-type-improvements.md) | main | In Progress | [jcouv](https://github.com/jcouv) | [AlekseyTs](https://github.com/AlekseyTs), [cston](https://github.com/cston) |  | [jcouv](https://github.com/jcouv) |
+| Implicit indexer access in object initializers | main | Merged into 17.9p3 | [jcouv](https://github.com/jcouv) |  |  |  |
 
 # C# 12.0
 

eng/Version.Details.xml

@@ -27,14 +27,14 @@
     </Dependency>
   </ProductDependencies>
   <ToolsetDependencies>
-    <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="9.0.0-beta.23604.3">
+    <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="9.0.0-beta.23606.1">
       <Uri>https://github.com/dotnet/arcade</Uri>
-      <Sha>29736c3a40dc33e94b8a7fdf72dad6d441f9e46f</Sha>
+      <Sha>71149d1f281ab5e066d1f524f4862152683f5144</Sha>
       <SourceBuild RepoName="arcade" ManagedOnly="true" />
     </Dependency>
-    <Dependency Name="Microsoft.DotNet.XliffTasks" Version="9.0.0-beta.23604.3">
+    <Dependency Name="Microsoft.DotNet.XliffTasks" Version="9.0.0-beta.23606.1">
       <Uri>https://github.com/dotnet/arcade</Uri>
-      <Sha>29736c3a40dc33e94b8a7fdf72dad6d441f9e46f</Sha>
+      <Sha>71149d1f281ab5e066d1f524f4862152683f5144</Sha>
     </Dependency>
     <Dependency Name="Microsoft.DiaSymReader" Version="2.0.0">
       <Uri>https://github.com/dotnet/symreader</Uri>
@@ -49,9 +49,9 @@
       <Uri>https://github.com/dotnet/roslyn</Uri>
       <Sha>5d10d428050c0d6afef30a072c4ae68776621877</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="9.0.0-beta.23604.3">
+    <Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="9.0.0-beta.23606.1">
       <Uri>https://github.com/dotnet/arcade</Uri>
-      <Sha>29736c3a40dc33e94b8a7fdf72dad6d441f9e46f</Sha>
+      <Sha>71149d1f281ab5e066d1f524f4862152683f5144</Sha>
     </Dependency>
     <Dependency Name="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0-preview.23468.1">
       <Uri>https://github.com/dotnet/roslyn-analyzers</Uri>

eng/Versions.props

@@ -209,7 +209,7 @@
     <MicrosoftVisualStudioWorkspaceVSIntegrationVersion>17.1.11-preview-0002</MicrosoftVisualStudioWorkspaceVSIntegrationVersion>
     <MicrosoftWin32PrimitivesVersion>4.3.0</MicrosoftWin32PrimitivesVersion>
     <MicrosoftWin32RegistryVersion>5.0.0</MicrosoftWin32RegistryVersion>
-    <MSBuildStructuredLoggerVersion>2.1.858</MSBuildStructuredLoggerVersion>
+    <MSBuildStructuredLoggerVersion>2.2.100</MSBuildStructuredLoggerVersion>
     <MDbgVersion>0.1.0</MDbgVersion>
     <MonoOptionsVersion>6.6.0.161</MonoOptionsVersion>
     <MoqVersion>4.10.1</MoqVersion>

global.json

@@ -12,7 +12,7 @@
     "xcopy-msbuild": "17.8.1-2"
   },
   "msbuild-sdks": {
-    "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.23604.3",
-    "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.23604.3"
+    "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.23606.1",
+    "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.23606.1"
   }
 }

src/Analyzers/CSharp/Analyzers/UseCollectionExpression/CSharpUseCollectionExpressionForArrayDiagnosticAnalyzer.cs

@@ -4,6 +4,7 @@
 
 using System.Collections.Immutable;
 using System.Diagnostics;
+using System.Linq;
 using System.Threading;
 using Microsoft.CodeAnalysis.CodeStyle;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
@@ -14,6 +15,8 @@
 
 namespace Microsoft.CodeAnalysis.CSharp.UseCollectionExpression;
 
+using static SyntaxFactory;
+
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
 internal sealed partial class CSharpUseCollectionExpressionForArrayDiagnosticAnalyzer()
     : AbstractCSharpUseCollectionExpressionDiagnosticAnalyzer(
@@ -116,8 +119,14 @@ private void AnalyzeArrayInitializerExpression(SyntaxNodeAnalysisContext context
             ? (ExpressionSyntax)initializer.GetRequiredParent()
             : initializer;
 
+        // Have to actually examine what would happen when we do the replacement, as the replaced value may interact
+        // with inference based on the values within.
+        var replacementCollectionExpression = CollectionExpression(
+            SeparatedList<CollectionElementSyntax>(initializer.Expressions.Select(ExpressionElement)));
+
         if (!UseCollectionExpressionHelpers.CanReplaceWithCollectionExpression(
-                semanticModel, arrayCreationExpression, expressionType, skipVerificationForReplacedNode: true, cancellationToken))
+                semanticModel, arrayCreationExpression, replacementCollectionExpression,
+                expressionType, skipVerificationForReplacedNode: true, cancellationToken))
         {
             return;
         }

src/Analyzers/CSharp/Analyzers/UseCollectionExpression/UseCollectionExpressionHelpers.cs

@@ -41,6 +41,21 @@ public static bool CanReplaceWithCollectionExpression(
         INamedTypeSymbol? expressionType,
         bool skipVerificationForReplacedNode,
         CancellationToken cancellationToken)
+    {
+        // To keep things simple, all we do is replace the existing expression with the `[]` literal.This is an
+        // 'untyped' collection expression literal, so it tells us if the new code will have any issues moving to
+        // something untyped.  This will also tell us if we have any ambiguities (because there are multiple destination
+        // types that could accept the collection expression).
+        return CanReplaceWithCollectionExpression(semanticModel, expression, s_emptyCollectionExpression, expressionType, skipVerificationForReplacedNode, cancellationToken);
+    }
+
+    public static bool CanReplaceWithCollectionExpression(
+        SemanticModel semanticModel,
+        ExpressionSyntax expression,
+        CollectionExpressionSyntax replacementExpression,
+        INamedTypeSymbol? expressionType,
+        bool skipVerificationForReplacedNode,
+        CancellationToken cancellationToken)
     {
         var compilation = semanticModel.Compilation;
 
@@ -91,13 +106,10 @@ public static bool CanReplaceWithCollectionExpression(
             return IsConstructibleCollectionType(semanticModel.GetTypeInfo(parent, cancellationToken).Type);
 
         // Looks good as something to replace.  Now check the semantics of making the replacement to see if there would
-        // any issues.  To keep things simple, all we do is replace the existing expression with the `[]` literal. This
-        // is an 'untyped' collection expression literal, so it tells us if the new code will have any issues moving to
-        // something untyped.  This will also tell us if we have any ambiguities (because there are multiple destination
-        // types that could accept the collection expression).
+        // any issues.
         var speculationAnalyzer = new SpeculationAnalyzer(
             topMostExpression,
-            s_emptyCollectionExpression,
+            replacementExpression,
             semanticModel,
             cancellationToken,
             skipVerificationForReplacedNode,