Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block 'use collection expression' on certain types #71154

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #71145

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 7, 2023 18:59
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 7, 2023
Comment on lines +66 to +68
private static readonly ImmutableHashSet<string?> s_bannedTypes = ImmutableHashSet.Create<string?>(
nameof(ParallelEnumerable),
nameof(ParallelQuery));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It felt weird that we aren't doing namespace checks here, but I guess if anybody else calls their types these names, we probably should stay away too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup.

@CyrusNajmabadi CyrusNajmabadi merged commit 4961ff9 into dotnet:main Dec 7, 2023
20 of 24 checks passed
@ghost ghost added this to the Next milestone Dec 7, 2023
@CyrusNajmabadi CyrusNajmabadi deleted the useCollectionBlockList branch December 7, 2023 21:00
@Cosifne Cosifne modified the milestones: Next, 17.9 P3 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE0305 Introduces Race Condition
3 participants