Provide overloads to avoid unnecessary boxing #71894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
src/Compilers/Core/Portable/Collections/ImmutableArrayExtensions.cs
Outdated
Show resolved
Hide resolved
src/Compilers/Core/Portable/Collections/ImmutableArrayExtensions.cs
Outdated
Show resolved
Hide resolved
sharwell
force-pushed
the
unnecessary-box
branch
from
da8c785 to
5f8e721
Compare
CyrusNajmabadi
approved these changes
Jan 31, 2024
sharwell
commented
Jan 31, 2024
| /// <param name="predicate">The condition to use for filtering the array content.</param> | ||
| /// <param name="selector">A transform function to apply to each element that is not filtered out by <paramref name="predicate"/>.</param> | ||
| /// <returns>If the items's length is 0, this will return an empty immutable array.</returns> | ||
| public static ImmutableArray<TResult> SelectManyAsArray<TItem, TResult>(this ImmutableArray<TItem> array, Func<TItem, bool> predicate, Func<TItem, ImmutableArray<TResult>> selector) |
There was a problem hiding this comment.
📝 There were two callers of the previous overload prior to this change. After this change, there is one caller of the previous overload, and one caller of the new overload.
| /// <param name="array">The array to transform</param> | ||
| /// <param name="selector">A transform function to apply to each element.</param> | ||
| /// <returns>If the array's length is 0, this will return an empty immutable array.</returns> | ||
| public static ImmutableArray<TResult> SelectManyAsArray<TItem, TResult>(this ImmutableArray<TItem> array, Func<TItem, ImmutableArray<TResult>> selector) |
There was a problem hiding this comment.
📝 There were 16 callers of the previous overload prior to this change. After this change, there are 3 callers of the previous overload, and 13 callers of the new overload.
333fred
approved these changes
Jan 31, 2024
jjonescz
approved these changes
Feb 1, 2024
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.