Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust public API based on API review feedback #71940

Merged
merged 1 commit into from
Feb 5, 2024

Adjust public API based on API review feedback

a5eb042
Select commit
Loading
Failed to load commit list.
Merged

Adjust public API based on API review feedback #71940

Adjust public API based on API review feedback
a5eb042
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Feb 2, 2024 in 0s

.NET Result Analysis

Details

Test Failures (12 tests failed)

🔹 [All failing tests from roslyn-integration-CI]

    ⚠️ 4 failing tests not displayed for this pipeline due to space limitations

    ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpAddMissingReference.InvokeSomeFixesInCSharpThenVerifyReferences [Details] [100.00% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configurations (2)
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpAddMissingReference.InvokeSomeFixesInCSharpThenVerifyReferences (VS2022)
      Exception Message
      Assert.Contains() Failure
Not found: System.Windows.Forms,4.0.0.0,B77A5C561934E089
In value:  String[] ["System,4.0.0.0,B77A5C561934E089", "System.Core,4.0.0.0,B77A5C561934E089", "System.Xml.Linq,4.0.0.0,B77A5C561934E089", "System.Data.DataSetExtensions,4.0.0.0,B77A5C561934"..., "Microsoft.CSharp,4.0.0.0,B03F5F7F11D50A3A", ...]
      Stack Trace
         at Roslyn.VisualStudio.IntegrationTests.InProcess.SolutionExplorerVerifierInProcess.<AssemblyReferencePresentAsync>d__2.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionExplorerVerifierInProcess.cs:line 76
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpAddMissingReference.<InvokeSomeFixesInCSharpThenVerifyReferences>d__13.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpAddMissingReference.cs:line 167
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpArgumentProvider.EnsureParameterContentPreserved [Details] [17.00% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configurations (2)
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpArgumentProvider.EnsureParameterContentPreserved(parameterText: "\" \"") (VS2022)
      Exception Message
      Assert.Equal() Failure
                        ↓ (pos 14)
Expected:         M("  ", 0)
Actual:           M("  "", 0)
                        ↑ (pos 14)
      Stack Trace
         at Roslyn.VisualStudio.IntegrationTests.InProcess.EditorVerifierInProcess.<CurrentLineTextAsync>d__4.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorVerifierInProcess.cs:line 39
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpArgumentProvider.<EnsureParameterContentPreserved>d__16.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpArgumentProvider.cs:line 493
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpArgumentProvider.EnsureParameterContentPreserved(parameterText: "\"$placeholder$\"") (VS2022)
      Exception Message
      Assert.Equal() Failure
                                 ↓ (pos 25)
Expected: ···   M("$placeholder$", 0)
Actual:   ···   M("$placeholder$"", 0)
                                 ↑ (pos 25)
      Stack Trace
         at Roslyn.VisualStudio.IntegrationTests.InProcess.EditorVerifierInProcess.<CurrentLineTextAsync>d__4.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorVerifierInProcess.cs:line 39
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpArgumentProvider.<EnsureParameterContentPreserved>d__16.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpArgumentProvider.cs:line 493
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpArgumentProvider.EnsureParameterContentPreserved(parameterText: "\"&\"") (VS2022)
      Exception Message
      Assert.Equal() Failure
                       ↓ (pos 13)
Expected:         M("&", 0)
Actual:           M("&"", 0)
                       ↑ (pos 13)
      Stack Trace
         at Roslyn.VisualStudio.IntegrationTests.InProcess.EditorVerifierInProcess.<CurrentLineTextAsync>d__4.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorVerifierInProcess.cs:line 39
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpArgumentProvider.<EnsureParameterContentPreserved>d__16.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpArgumentProvider.cs:line 493
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpArgumentProvider.TabTabCompletionWithArguments [Details] [100.00% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configurations (2)
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpArgumentProvider.TabTabCompletionWithArguments (VS2022)
      Exception Message
      Assert.Equal() Failure
          ↓ (pos 0)
Expected: , provider)
Actual:   ", provider)
          ↑ (pos 0)
      Stack Trace
         at Roslyn.VisualStudio.IntegrationTests.InProcess.EditorVerifierInProcess.<CurrentLineTextAndAssertCaretPositionAsync>d__5.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorVerifierInProcess.cs:line 63
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Roslyn.VisualStudio.IntegrationTests.InProcess.EditorVerifierInProcess.<CurrentLineTextAsync>d__4.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorVerifierInProcess.cs:line 34
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpArgumentProvider.<TabTabCompletionWithArguments>d__8.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpArgumentProvider.cs:line 183
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    ❌ Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicAddMissingReference.InvokeSomeFixesInVisualBasicThenVerifyReferences [Details] [100.00% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configurations (2)
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicAddMissingReference.InvokeSomeFixesInVisualBasicThenVerifyReferences (VS2022)
      Exception Message
      Assert.Contains() Failure
Not found: System.Windows.Forms,4.0.0.0,B77A5C561934E089
In value:  String[] ["System,4.0.0.0,B77A5C561934E089", "System.Data,4.0.0.0,B77A5C561934E089", "System.Deployment,4.0.0.0,B03F5F7F11D50A3A", "System.Xml,4.0.0.0,B77A5C561934E089", "System.Core,4.0.0.0,B77A5C561934E089", ...]
      Stack Trace
         at Roslyn.VisualStudio.IntegrationTests.InProcess.SolutionVerifierInProcess.<AssemblyReferencePresentAsync>d__0.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionVerifierInProcess.cs:line 19
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicAddMissingReference.<InvokeSomeFixesInVisualBasicThenVerifyReferences>d__12.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/VisualBasic/BasicAddMissingReference.cs:line 174
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

🔹 [All failing tests from roslyn-integration-corehost]

    ⚠️ 3 failing tests not displayed for this pipeline due to space limitations

    ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpAddMissingReference.InvokeSomeFixesInCSharpThenVerifyReferences [Details] [100.00% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpAddMissingReference.InvokeSomeFixesInCSharpThenVerifyReferences (VS2022)
      Exception Message
      Assert.Contains() Failure
Not found: System.Windows.Forms,4.0.0.0,B77A5C561934E089
In value:  String[] ["System,4.0.0.0,B77A5C561934E089", "System.Core,4.0.0.0,B77A5C561934E089", "System.Xml.Linq,4.0.0.0,B77A5C561934E089", "System.Data.DataSetExtensions,4.0.0.0,B77A5C561934"..., "Microsoft.CSharp,4.0.0.0,B03F5F7F11D50A3A", ...]
      Stack Trace
         at Roslyn.VisualStudio.IntegrationTests.InProcess.SolutionExplorerVerifierInProcess.<AssemblyReferencePresentAsync>d__2.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionExplorerVerifierInProcess.cs:line 76
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpAddMissingReference.<InvokeSomeFixesInCSharpThenVerifyReferences>d__13.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpAddMissingReference.cs:line 167
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Was this helpful? Yes No

View more details on Build Analysis