Reduce allocations required to create a TransformNode #72375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of wrapping the user function and passing that into the TransformNode ctor, we instead give the option of passing in a flag to indicate whether the TransformNode should do the try/catch itself. I believe this will save about 0.5% in allocations in the RichCopyTest.CopyPlain speedometer test and will do a test insertion to validate, keeping this as a draft PR until validated.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
ToddGrun
changed the title
|
@dotnet/roslyn-compiler -- ptal |
jjonescz
approved these changes
Mar 5, 2024
|
Any thoughts @chsienki ? |
chsienki
reviewed
Mar 6, 2024
| throw new UserFunctionException(e); | ||
| } | ||
| } | ||
| else |
There was a problem hiding this comment.
We could get rid of the if/else and edit the when on the catch so we don't catch if !_wrapUserFunc
I'd then renamed _wrapUserFunc to just CatchAnalyzerExceptions
There was a problem hiding this comment.
Went ahead and made the modification to the when clause.
I can be convinced otherwise, but I think I'd prefer to keep the current name (_wrapUserFunc) as the existing _func name doesn't convey a relationship to analyzers.
There was a problem hiding this comment.
Generators are analyzers too, we sort of use the terms interchangeably inside the compiler, but I also don't have strong feelings on the naming.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
chsienki
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of wrapping the user function and passing that into the TransformNode ctor, we instead give the option of passing in a flag to indicate whether the TransformNode should do the try/catch itself.
This looks to save about 0.5% in allocations in the RichCopyTest.CopyPlain speedometer via results here from this test insertion.