Don't recommend readonly after readonly #72394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Mar 5, 2024
|
Thanks! |
|
@CyrusNajmabadi seems a CI test broke and another might be stalling, but they don't look normal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72372
This pr does 2 changes to address the issue:
On the second point, this is because while it is possible to have both readonly and partial, it is not possible to have readonly appear AFTER partial while being syntactically valid. This means that effectively, if we already have partial, readonly shouldn't be recommended.
While investigating, I found that existing tests seemed to have enforced the opposite. Particularly, it seemed there was a test that was testing that readonly was recommended right after it. I changed those tests too.