Use the project cone information in Scope.FindAssetsAsync (part 2) #72512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids full solution level searches in scenarios where a project cone is being searched. This was particularly bad when the AssetHint didn't indicate a project/document.
…nScope.FindAssetsAsync
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 12, 2024
| @@ -14,6 +14,21 @@ | |||
|
|
|||
| namespace Microsoft.CodeAnalysis; | |||
|
|
|||
| internal readonly struct ProjectCone(ProjectId rootProjectId, IReadOnlySet<ProjectId> projectIds) : IEquatable<ProjectCone> | |||
There was a problem hiding this comment.
Core idea is that we have a strongly-typed view of the cone that we can capture in the scope object. That cone info can help reduce unnecessary work with syncing.
ToddGrun
reviewed
Mar 12, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState_Checksum.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Mar 12, 2024
| return AsyncLazy.Create(static (arg, c) => | ||
| arg.self.ComputeChecksumsAsync(arg.projectConeId, c), | ||
| arg: (self: this, projectConeId)); | ||
| } |
There was a problem hiding this comment.
inlined this. no need for the local function since Todd moved this to static lambdas.
CyrusNajmabadi
commented
Mar 12, 2024
| _lazyChecksums = AsyncLazy.Create(static (self, c) => | ||
| self.ComputeChecksumsAsync(projectId: null, c), | ||
| arg: this); | ||
| _lazyChecksums = AsyncLazy.Create(static async (self, cancellationToken) => |
There was a problem hiding this comment.
style preference. i like to use cancellationToken for callbacks. that way if there is a cancellationToken in scope, it will hide it and we don't accidentally capture the wrong thing. less relevant for static lambdas. but i like to be consistent with that.
ToddGrun
reviewed
Mar 12, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState_Checksum.cs
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #72509.
This avoids full solution level searches in scenarios where a project cone is being searched. This was particularly bad when the AssetHint didn't indicate a project/document.