Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Razor EA #73040

Merged
merged 8 commits into from
May 30, 2024
Merged

Clean up Razor EA #73040

merged 8 commits into from
May 30, 2024

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier commented Apr 16, 2024 •
edited
Loading

Now that Razor is on dynamic registration, we don't need our own server for cohosting.

Part of dotnet/razor#9519

@davidwengier davidwengier requested a review from a team as a code owner April 16, 2024 03:02
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 16, 2024
@davidwengier @ady109
Update src/Tools/ExternalAccess/Razor/Cohost/AbstractRazorLspService.cs
a28b97a 
Co-authored-by: ady109 <149323961+ady109@users.noreply.github.com>
@davidwengier davidwengier mentioned this pull request Apr 16, 2024
Open
@build-analysis build-analysis bot mentioned this pull request Apr 16, 2024
Open
3 tasks
@davidwengier davidwengier requested review from dibarbet and a team April 23, 2024 05:45
@davidwengier davidwengier enabled auto-merge April 23, 2024 23:22
@davidwengier
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

auto-merge was automatically disabled April 24, 2024 10:59

Pull Request is not mergeable

@davidwengier
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@davidwengier davidwengier mentioned this pull request May 17, 2024
Merged
@davidwengier
Merge remote-tracking branch 'upstream/main' into CleanupRazorEA
92563d4 
# Conflicts:
#	src/Tools/ExternalAccess/Razor/Cohost/RazorCohostLanguageClient.cs
@davidwengier
Add back missing interface
c4dcbac
alexgav
alexgav approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier
Copy link
Contributor Author

Woohoo, images were updated, I can merge this!

@davidwengier davidwengier merged commit 7185315 into dotnet:main May 30, 2024
25 checks passed
@davidwengier davidwengier deleted the CleanupRazorEA branch May 30, 2024 23:32
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 30, 2024
This was referenced Jun 4, 2024
Closed
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ady109 ady109 ady109 left review comments

@dibarbet dibarbet dibarbet approved these changes

@alexgav alexgav alexgav approved these changes

@DustinCampbell DustinCampbell DustinCampbell approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P3
Development

Successfully merging this pull request may close these issues.
6 participants
@davidwengier @DustinCampbell @alexgav @dibarbet @ady109 @jjonescz