Handle ref safety analysis for type parameters with 'allows ref struct' constraint #73281
Conversation
dotnet-issue-labeler
bot
added
the
untriaged
1 similar comment
| case BoundKind.NewT: | ||
| { | ||
| var newT = (BoundNewT)expr; | ||
| var constructorSymbol = newT.Constructor; |
| @@ -663,7 +663,9 @@ private BoundExpression EvaluateSideEffects(BoundExpression arg, RefKind refKind | |||
|
|
|||
| #if DEBUG | |||
| var discardedUseSiteInfo = CompoundUseSiteInfo<AssemblySymbol>.Discarded; | |||
| Debug.Assert(_compilation.Conversions.ClassifyConversionFromType(rewrittenReceiver.Type, memberSymbol.ContainingType, isChecked: false, ref discardedUseSiteInfo).IsImplicit); | |||
| // PROTOTYPE(RefStructInterfaces): Test various flavors of object/collection initializers on a type parameter that allows ref struct | |||
| Debug.Assert(_compilation.Conversions.ClassifyConversionFromType(rewrittenReceiver.Type, memberSymbol.ContainingType, isChecked: false, ref discardedUseSiteInfo).IsImplicit || | |||
There was a problem hiding this comment.
_compilation.Conversions.ClassifyConversionFromType(rewrittenReceiver.Type, memberSymbol.ContainingType, isChecked: false, ref discardedUseSiteInfo).IsImplicit ||
It looks like this check can be dropped since it is included in HasImplicitConversionToOrImplementsVarianceCompatibleInterface(). #Resolved
There was a problem hiding this comment.
It looks like this check can be dropped since it is included in
HasImplicitConversionToOrImplementsVarianceCompatibleInterface().
It actually isn't. HasImplicitConversionToOrImplementsVarianceCompatibleInterface deals only with interfaces.
|
|
||
| RS M1() | ||
| { | ||
| // RSTE of `this` is CurrentMethod |
There was a problem hiding this comment.
thisis an interface, not a type parameter withallows ref struct.
And the point you are trying to make is?
There was a problem hiding this comment.
The test didn't seem particularly interesting to me because this is an interface and not by-ref-like. But the behavior (no errors reported) looks correct.
There was a problem hiding this comment.
The behavior is different by comparison to the cloned test, but correct. That feels good enough to keep the test.
AlekseyTs
merged commit 0433c09
into
dotnet:features/RefStructInterfaces
No description provided.