Improve analyzer consistency check message #73329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the message when analyzer consistency checks fail to use the original location for both the requested load and the initial load. Previously the initial load was showing the shadow copy path. That is _much_ less actionable by customers. Before > CompilerServer: server failed - server rejected the request due to analyzer / generator issues 'analyzer assembly 'e:\nuget\packages\microsoft.extensions.logging.abstractions\6.0.0\analyzers\dotnet\roslyn3.11\cs\Microsoft.Extensions.Logging.Generators.dll' has MVID '411719f3-42a9-4e21-8529-264aea08538c' but loaded assembly 'C:\Users\jaredpar\AppData\Local\Temp\VBCSCompiler\AnalyzerAssemblyLoader\ae4813f7a72847839648de6bc4d9dffd\26\Microsoft.Extensions.Logging.Generators.dll' has MVID '620a3d95-9a61-4671-81a7-5380bd2e5574' After > CompilerServer: server failed - server rejected the request due to analyzer / generator issues 'analyzer assembly 'e:\nuget\packages\microsoft.extensions.logging.abstractions\6.0.0\analyzers\dotnet\roslyn3.11\cs\Microsoft.Extensions.Logging.Generators.dll' has MVID '411719f3-42a9-4e21-8529-264aea08538c' but loaded assembly 'e:\nuget\.nuget\packages\microsoft.extensions.logging.abstractions\6.0.0\analyzers\dotnet\roslyn4.0\cs\Microsoft.Extensions.Logging.Generators.dll' has MVID '620a3d95-9a61-4671-81a7-5380bd2e5574'
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
|
@dotnet/roslyn-compiler PTAL |
2 tasks
333fred
approved these changes
May 4, 2024
jjonescz
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the message when analyzer consistency checks fail to use the original location for both the requested load and the initial load. Previously the initial load was showing the shadow copy path. That is much less actionable by customers.
Before
After