Properly dispose the SymbolSearchEngine #73464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 14, 2024
| public void Dispose() | ||
| { | ||
| // Nothing to do for the no-op version. | ||
| } |
There was a problem hiding this comment.
Note: the actual Dispose we care about already exists, but is currently not called through any codepaths. It is here:
What thsi PR does is hook things up to ensure that it is called. To ensure that we actually dispose the RemoteServiceConnection instance we're holding onto.
|
@ToddGrun ptal |
CyrusNajmabadi
commented
May 14, 2024
| _lazyUpdateEngine = SymbolSearchUpdateNoOpEngine.Instance; | ||
| } | ||
|
|
||
| updateEngine?.Dispose(); |
There was a problem hiding this comment.
needed so this searc-service release the underlying ISymbolSearchUpdateEngine, which will release the connection we have with the oop server.
ToddGrun
reviewed
May 14, 2024
| public void Dispose() | ||
| { | ||
| ISymbolSearchUpdateEngine? updateEngine; | ||
| using (_gate.DisposableWait()) |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while investigating post-VS shutdown issues with Dave.