-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move AsyncBatchingWorkQueue usage in telemetry to TelemetryLogging level #73485
Move AsyncBatchingWorkQueue usage in telemetry to TelemetryLogging level #73485
Conversation
…ogging le…" This reverts commit 4bbcd1d.
…e and forget mechanism 2) Cleanup _findDocumentResults and _usedForkedSolutionCounter after their data has been flushed.
Test insertion (as I broke insertions with the previous iteration of this) didn't hit the same issues as the previous PR was causing. https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/551162 |
What was different this time around,(will review when I get in the office) |
The first commit is strictly the revert. The second commit is the changes this time around. The issue was as you had originally thought, we were pushing an item into the ABWQ immediately after finishing the prior one (the code used to wait until a telemetry event was fired, but that didn't fit well with how things moved around). By pushing immediately into the ABWQ upon processing an item from it, the IAsynchronousOperationListener processing code would never complete. |
// Create a fire and forget task to handle the next collection. This doesn't use IAsynchronousOperationListener | ||
// to track this work as no-one needs to ensure this is sent, and the create a new item of work | ||
// upon previous completion doesn't fit well in that model. | ||
_ = PostCollectedTelemetryAsync(CancellationToken.None); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider wrapping with reportnonfatal (so we'll have non fatals if something goes wrong)
Reapply "Move AsyncBatchingWorkQueue usage in telemetry to TelemetryLogging"
This reverts commit 4bbcd1d (which was a reversion of 21181a7).
Original PR which introduced most of these changes: #73287
Additionally: