Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower the amount of time FAR spends in classification by 4% #73533

Merged
merged 1 commit into from
May 17, 2024
Merged

Lower the amount of time FAR spends in classification by 4% #73533

merged 1 commit into from
May 17, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented May 17, 2024 •
edited
Loading

Removes the cost of concurrent dictionaries here:

image

And lowers total cost from:

image

to:

image

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 17, 2024 06:44
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 17, 2024
@CyrusNajmabadi
Copy link
Member Author

@ToddGrun ptal

ToddGrun
ToddGrun reviewed May 17, 2024
View reviewed changes
src/Workspaces/Core/Portable/ExtensionManager/IExtensionManagerExtensions.cs

Func<Type, ImmutableArray<TExtension>> getExtensions = (Type t1) =>
foreach (var extension in extensions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extensions

I like it. Good observation that allowing it to not handle the subclass could simplify it like this.

The only concern would be the fragility when new types are added that need to be added to SyntaxNodeTypes, but I'm guessing that doesn't happen often anymore.

ToddGrun
ToddGrun approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge May 17, 2024 15:48
@CyrusNajmabadi CyrusNajmabadi merged commit 4251de7 into dotnet:main May 17, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 17, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the classificationExt branch May 17, 2024 17:11
This was referenced May 21, 2024
Closed
Closed
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @Cosifne