Batch FAR window update messages to lower refresh overhead. #73534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@ToddGrun ptal |
ToddGrun
reviewed
May 17, 2024
| // Similarly, updating the actual FAR window can be quite expensive (especially when there are thousands of | ||
| // results). To limit the amount of work we do, we'll only update the window every 500ms. | ||
| _notifyQueue = new AsyncBatchingWorkQueue( | ||
| DelayTimeSpan.Medium, |
There was a problem hiding this comment.
I kind of feel like I wish the ABWQ had an option where it would customize the delay as the work expanded.
Something like:
For the first 1 second, it updates on NearImmediate cadence.
Between 1 - 5 seconds, it updates on short cadence
After 5 seconds, it updates on medium cadence
It just feels like adding a 500 ms delay on really quick FAR requests might be perceptible.
There was a problem hiding this comment.
I def didn't notice anything feeling off here. I could make it 250ms if you feel better about that. We'll still likely get the majority of the benefit.
There was a problem hiding this comment.
I would like that. 250 ms is a lot less noticeable than 500 ms.
CyrusNajmabadi
commented
May 17, 2024
src/VisualStudio/Core/Def/FindReferences/Contexts/AbstractTableDataSourceFindUsagesContext.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
May 17, 2024
src/VisualStudio/Core/Def/FindReferences/Contexts/AbstractTableDataSourceFindUsagesContext.cs
Outdated
Show resolved
Hide resolved
|
@ToddGrun done |
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops CPu utilization in Devenv from 57Msecs in an expensive FAR scenario:
to just 34Msecs
--
While the FAR window is good, it's not good enough that thousands of notification updates dont' impact it.