Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not perform obsolete analysis in teh FAR scenario #73547

Merged
merged 5 commits into from
May 17, 2024
Merged

Do not perform obsolete analysis in teh FAR scenario #73547

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a1b12c
Avoid unnecessary allocations while finding token matches in a file
CyrusNajmabadi May 16, 2024
6e657be
Merge branch 'main' of https://github.com/CyrusNajmabadi/roslyn
CyrusNajmabadi May 17, 2024
55c52d1
Merge remote-tracking branch 'upstream/main'
CyrusNajmabadi May 17, 2024
ccfc34f
Do not perform obsolete analysis in teh FAR scenario
CyrusNajmabadi May 17, 2024
b4ed8a1
Revert
CyrusNajmabadi May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Features/Core/Portable/FindUsages/DefinitionItemFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,10 @@ private static ImmutableDictionary<string, string> GetProperties(ISymbol definit

var options = await optionsProvider.GetOptionsAsync(document.Project.Services, cancellationToken).ConfigureAwait(false);

// We don't want to classify obsolete symbols as it is very expensive, and it's not necessary for find all
// references to strike out code in the window displaying results.
options = options with { ClassifyObsoleteSymbols = false };

var documentSpan = new DocumentSpan(document, sourceSpan);
var classifiedSpans = await ClassifiedSpansAndHighlightSpanFactory.ClassifyAsync(
documentSpan, classifiedSpans: null, options, cancellationToken).ConfigureAwait(false);
Expand Down
Loading