Switch to a List as the backing store for the FAR window from an ImmutableList. #73589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
CyrusNajmabadi
changed the title
CyrusNajmabadi
commented
May 20, 2024
| ? EntriesWhenGroupingByDefinition | ||
| : EntriesWhenNotGroupingByDefinition; | ||
| ? EntriesWhenGroupingByDefinition.ToImmutableArray() | ||
| : EntriesWhenNotGroupingByDefinition.ToImmutableArray(); |
There was a problem hiding this comment.
here we make a snapshot to actually put into TableEntriesSnapshot. But this should be ok the vast majority of hte time. We're only updating this snapshot at most 4 times a second. So the amount of copies made by this is very small (didn't show up in any measurements). And the wins we get by just working with List vs an ImmutableList (which internally is an AVL tree) is substantive.
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #73587.
Saves several percent on looking up into the immutable array. As well as all hte overhead involved just mutating hte immutable-list (which is an AVL tree under the covers):