Add extract method support for ref struct interfaces #73619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method extraction code uses ITypeParameterSymbol's constraints to generate the new method's text. This codepath had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType This is in support of the "allows ref struct" on interfaces feature outlined here: #72124 This ref structs for interfaces feature was merged via this PR: #73567
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
May 21, 2024
AlekseyTs
reviewed
May 21, 2024
| @@ -18,6 +18,7 @@ | |||
| bool hasConstructorConstraint, | |||
| bool hasReferenceConstraint, | |||
| bool hasValueConstraint, | |||
| bool allowsRefLikeType, | |||
There was a problem hiding this comment.
re-ordered for the new parameter to be the last bool param
AlekseyTs
reviewed
May 21, 2024
| @@ -337,10 +338,11 @@ | |||
| bool hasReferenceConstraint = false, | |||
| bool hasUnmanagedConstraint = false, | |||
| bool hasValueConstraint = false, | |||
| bool allowsRefLikeType = false, | |||
There was a problem hiding this comment.
Especially that in CodeGenerationTypeParameterSymbol it comes before hasUnmanagedConstraint parameter.
ToddGrun
commented
May 21, 2024
| @@ -322,7 +322,8 @@ public static ITypeParameterSymbol CreateTypeParameterSymbol(string name, int or | |||
| attributes: default, varianceKind: VarianceKind.None, | |||
| name: name, constraintTypes: [], | |||
| hasConstructorConstraint: false, hasReferenceConstraint: false, hasValueConstraint: false, | |||
| hasUnmanagedConstraint: false, hasNotNullConstraint: false, ordinal: ordinal); | |||
| allowsRefLikeType: false, hasUnmanagedConstraint: false, hasNotNullConstraint: false, | |||
…ontext, but good to be consistent)
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method extraction code uses ITypeParameterSymbol's constraints to generate the new method's text. This codepath had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType
This is in support of the "allows ref struct" on interfaces feature outlined here: #72124
This ref structs for interfaces feature was merged via this PR: #73567