Reduce size of interval tree used for tagging #73703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 25, 2024
|
|
||
| internal partial class TagSpanIntervalTree<TTag> | ||
| { | ||
| private readonly struct TagNode(ITagSpan<TTag> tagSpan, SpanTrackingMode trackingMode) |
There was a problem hiding this comment.
no need to store the trackingMode in the node itself. all nodes within the TagSpanIntervalTree have hte same tracking mode. So this was redundant. at that point, this entire type was redundant as it was just wrapping the ITagSpan<TTag>
CyrusNajmabadi
commented
May 25, 2024
| public TagSpan<TTag> GetTranslatedTagSpan(ITextSnapshot textSnapshot) | ||
| => new(GetTranslatedSpan(textSnapshot), Tag); | ||
|
|
||
| public SnapshotSpan GetTranslatedSpan(ITextSnapshot textSnapshot) |
There was a problem hiding this comment.
these two helpers moved to statics on the outer type.
CyrusNajmabadi
commented
May 25, 2024
| @@ -48,7 +54,7 @@ public bool HasSpanThatContains(SnapshotPoint point) | |||
| var snapshot = point.Snapshot; | |||
| Debug.Assert(snapshot.TextBuffer == _textBuffer); | |||
|
|
|||
| return _tree.HasIntervalThatContains(point.Position, length: 0, new IntervalIntrospector(snapshot)); | |||
| return _tree.HasIntervalThatContains(point.Position, length: 0, new IntervalIntrospector(snapshot, _spanTrackingMode)); | |||
There was a problem hiding this comment.
instead of the node needing to hold onto the tracing mode, we just pass it through with the introspector (a lightweight struct) when queryign the tree.
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while doing other refactorings in this space to lower our overhead while tagging.