Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic snippets: allow cw snippet in void-returning lambdas #73706

Merged
merged 2 commits into from
May 29, 2024
Merged

Semantic snippets: allow cw snippet in void-returning lambdas #73706

merged 2 commits into from
May 29, 2024

Conversation

DoctorKrolic
Copy link
Contributor

Fixes: #72266

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner May 25, 2024 06:28
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 25, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 25, 2024
@DoctorKrolic @CyrusNajmabadi
Strengthen the constraint
0672f54 
Co-authored-by: Cyrus Najmabadi <cyrus.najmabadi@gmail.com>
@DoctorKrolic
Copy link
Contributor Author

Can I have a review here?

@DoctorKrolic
Copy link
Contributor Author

@akhera99

akhera99
akhera99 approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@akhera99 akhera99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@akhera99 akhera99 merged commit 392c26b into dotnet:main May 29, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 29, 2024
@DoctorKrolic DoctorKrolic deleted the write-line-in-lambda branch May 30, 2024 04:30
This was referenced Jun 4, 2024
Closed
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhera99 akhera99 akhera99 approved these changes

@CyrusNajmabadi CyrusNajmabadi Awaiting requested review from CyrusNajmabadi

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P3
Development

Successfully merging this pull request may close these issues.

Semantic snippets: cw snippet is not offered after lambda's arrow
4 participants
@DoctorKrolic @CyrusNajmabadi @akhera99 @jjonescz