Use a new consistent pattern for working with 'args' objects in callbacks #73749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 28, 2024
| @@ -228,11 +228,12 @@ private static bool IsHostOrRemoteWorkspace(Project project) | |||
| source: viableUnreferencedProjects, | |||
| produceItems: static async (project, onItemsFound, args, cancellationToken) => | |||
| { | |||
| var (projectToAssembly, allSymbolReferences, maxResults, finder, exact, linkedTokenSource) = args; | |||
There was a problem hiding this comment.
the pattern is to take the args parameter (which here was written as args: (projectToAssembly, allSymbolReferences, maxResults, finder, exact, linkedTokenSource), and just take that full tuple and copy it into the variable as what we are dconstructing into. Then, within the body, we can refer to all the nice names again instead of hte args.XXX in every single place.
There was a problem hiding this comment.
if we follow this pattern in the future, it will also make diffs easier, as the body code which got pushed into the lambda will stay the same.
CyrusNajmabadi
commented
May 28, 2024
src/Features/Core/Portable/AddImport/AbstractAddImportFeatureService.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
May 28, 2024
| @@ -75,14 +75,15 @@ internal static partial class FixAllContextHelper | |||
|
|
|||
| allDiagnostics = await ProducerConsumer<ImmutableArray<Diagnostic>>.RunParallelAsync( | |||
| source: projectsToFix, | |||
| produceItems: static async (projectToFix, callback, args, cancellationToken) => | |||
CyrusNajmabadi
commented
May 28, 2024
src/Workspaces/Core/Portable/CodeFixes/FixAllOccurrences/FixAllContextHelper.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
May 28, 2024
src/Workspaces/Core/Portable/CodeFixes/FixAllOccurrences/FixAllContextHelper.cs
Outdated
Show resolved
Hide resolved
3 tasks
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.