Run providers in parallel when determining if we should show the lightbulb icon #73758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 29, 2024
src/Features/Core/Portable/CodeRefactorings/CodeRefactoringService.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
May 29, 2024
| // We want to pass linkedTokenSource.Token here so that we can cancel the inner operation once the | ||
| // outer ProducerConsumer sees a single refactoring returned by any provider. | ||
| var refactoring = await @this.GetRefactoringFromProviderAsync( | ||
| document, state, provider, options, linkedTokenSource.Token).ConfigureAwait(false); |
There was a problem hiding this comment.
It should not be possible. we only dispose after the call to RunParallelAsync has completed. And it only completes Asher both the producer and consumer complete.
There was a problem hiding this comment.
took a minute to process, but yeah, that makes sense. Thanks!
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when determining if the lightbulb shoudl appear, we run providers serially, ending up with a long serial chain of costs like so:
individually providers aren't that expensive. But when we have dozens to hundreds of them, this adds up.
This PR switches to running them in parallel, canceling either whne we are told to stop, or the moment we find one that has a refactoring.