-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge partial properties feature to main #73815
Merged
RikkiGibson
merged 22 commits into
dotnet:main
from
RikkiGibson:partial-properties-to-main
May 31, 2024
Merged
Merge partial properties feature to main #73815
RikkiGibson
merged 22 commits into
dotnet:main
from
RikkiGibson:partial-properties-to-main
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-merge-main Update partial properties feature branch from main
…-merge-main Update partial properties feature branch from main
Co-authored-by: Cyrus Najmabadi <cyrus.najmabadi@gmail.com>
Update partial properties feature branch from main
…roperires Address a few locations also need to care about partial properties
Co-authored-by: Shen Chen <Cosifne@users.noreply.github.com>
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
May 31, 2024
jaredpar
approved these changes
May 31, 2024
This was referenced Jun 4, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#73090
@jaredpar for review
There were merge conflicts merging the feature branch directly to main, pulling main in locally resolved them automatically. That happens now and then, who knows why.