Ignore workspaces that do not have IEditAndContinueWorkspaceService #73861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Interactive
untriaged
|
@dibarbet @jasonmalinowski Any idea what workspace doesn't have features layer? |
|
@tmat: oh strange; the only workspaces I can imagine would be somebody who created their own workspaces with the Default MEF services...but then how those ended up getting in a place where ENC is trying to operate doesn't make sense to me. If you want to request cabs on this one that might be wise; maybe this is really a setup issue where assemblies didn't get loaded? |
|
Approving after chatting with Tomas. He's requested cabs, but we'd like to avoid this from getting hit in new builds. |
|
Will follow up on the memory dump, once we get one. |
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2048920
Workspaces that do not include Features layer wouldn't have the service (not sure what those are though).