Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LanguageServer.Protocol.Test.Utilities.csproj #74036

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

tmat
Copy link
Member

@tmat tmat commented Jun 17, 2024

As with other Test.Utilities projects, this is a project to define test helpers/mocks for that layer.

@tmat tmat requested review from a team as code owners June 17, 2024 23:27
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 17, 2024
@tmat
Copy link
Member Author

tmat commented Jun 17, 2024

@dibarbet PTAL

BTW, seems like the LSP layer is being tested only with the editor, which means we only test on Windows :(

@dibarbet
Copy link
Member

@dibarbet PTAL

BTW, seems like the LSP layer is being tested only with the editor, which means we only test on Windows :(

Yup. There shouldn't be anything fundamental about the LSP tests that require it. The last time I looked the main issue was that the TestWorkspace was not compatible with non-windows platforms (some WPF concept in it).

@dibarbet
Copy link
Member

@dibarbet PTAL
BTW, seems like the LSP layer is being tested only with the editor, which means we only test on Windows :(

Yup. There shouldn't be anything fundamental about the LSP tests that require it. The last time I looked the main issue was that the TestWorkspace was not compatible with non-windows platforms (some WPF concept in it).

Although there were possibly some tests that required the editorfeatures composition (for testing custom VS LSP stuff). But those tests are expected to only run on windows.

@tmat tmat enabled auto-merge (squash) June 19, 2024 16:19
@tmat tmat merged commit e5ba426 into dotnet:main Jun 19, 2024
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 19, 2024
@tmat tmat deleted the LspTestUtils branch June 19, 2024 18:07
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants