Correctly define versions for runtime dependencies #74060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
dotnet-policy-service
bot
added
the
Community
|
@jasonmalinowski @jjonescz please approve. This needs to go in before P6 branch off today. |
jjonescz
approved these changes
Jun 19, 2024
System.ComponentModel.Composition and System.IO.Hashing were missing Versions.props and Version.Details.xml entries. This is necessary so that the VMR can upgrade the dependencies when building all dependencies live. Similar to c74b31b Unblocks runtime dependency flow: dotnet/sdk#41616
|
@ViktorHofer there are build errors |
ViktorHofer
force-pushed
the
FixCPMVersionsForLiveUpgrade
branch
from
18ed28c to
6421342
Compare
|
Just fixed them |
3 tasks
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.ComponentModel.Composition and
System.IO.Hashing were missing Versions.props and
Version.Details.xml entries.
This is necessary so that the VMR can upgrade
the dependencies when building all dependencies
live.
Similar to c74b31b Unblocks runtime dependency flow:
dotnet/sdk#41616