Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move settings updates into a queue. #74249

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Move settings updates into a queue. #74249

merged 2 commits into from
Jul 3, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Followup to #74247

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner July 2, 2024 21:05
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 2, 2024
@CyrusNajmabadi CyrusNajmabadi requested a review from ToddGrun July 2, 2024 21:06
@CyrusNajmabadi
Copy link
Member Author

@ToddGrun ptal.

ToddGrun
ToddGrun reviewed Jul 3, 2024
View reviewed changes
src/EditorFeatures/Core/EditorConfigSettings/Aggregator/SettingsAggregatorFactory.cs Outdated
[ImportingConstructor]
[Obsolete(MefConstruction.ImportingConstructorMessage, error: true)]
public SettingsAggregatorFactory()
public SettingsAggregatorFactory(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public SettingsAggregatorFactory(

nit: isn't your reflex to switch these to default ctor syntax?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. will do in that other mop up pr.

ToddGrun
ToddGrun reviewed Jul 3, 2024
View reviewed changes
src/EditorFeatures/Core/EditorConfigSettings/Aggregator/SettingsAggregator.cs Outdated
_namingStyleProvider = GetOptionsProviderFactory<NamingStyleSetting>(_workspace);
_analyzerProvider = GetOptionsProviderFactory<AnalyzerSetting>(_workspace);

//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//

nit: comment MIA :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. will do in that other mop up pr.

ToddGrun
ToddGrun approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge July 3, 2024 18:07
@build-analysis build-analysis bot mentioned this pull request Jul 3, 2024
Open
3 tasks
@dotnet-policy-service dotnet-policy-service bot added Needs UX Triage Needs API Review Needs to be reviewed by the API review council labels Jul 3, 2024
@CyrusNajmabadi CyrusNajmabadi merged commit 221738b into dotnet:main Jul 3, 2024
3 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the optionPerf2 branch July 3, 2024 20:47
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 3, 2024
This was referenced Jul 9, 2024
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE Needs API Review Needs to be reviewed by the API review council Needs UX Triage untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @RikkiGibson