-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async rename commit #74794
base: main
Are you sure you want to change the base?
Async rename commit #74794
Conversation
@@ -817,6 +849,7 @@ await DismissUIAndRollbackEditsAndEndRenameSessionAsync( | |||
|
|||
private async Task CommitCoreAsync(IUIThreadOperationContext operationContext, bool previewChanges) | |||
{ | |||
CommitStateChange?.Invoke(this, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this event for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Serious question: why do we have hte legacy UI. We've had the new UI for at least a year now. I would ask that we have a PR before thsi one that just rips it out and simplifies things greatly. |
@ryzngard knows more here, but for me it's a fallback safe plan when things broken in new UI. |
Make commit operation async in renaming session if the commit behavior is triggered by
enter
or in the rename UI.Rename behavior could be reversed back to sync mode by setting
InlineRenameSessionOptionsStorage.RenameAsynchronously
tofalse
.How it looks:
In legacy UI, if the renaming operation takes long time:
In new UI, if the renaming operation takes long time: