Re-enable double-to-integer conversion tests #74980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
force-pushed
the
74026-ConversionTests
branch
from
0469308
to
b4d3867
Compare
jjonescz
force-pushed
the
74026-ConversionTests
branch
from
b4d3867
to
8bde0d3
Compare
jaredpar
reviewed
Sep 3, 2024
| ' CheckDouble(Integer.MaxValue + 2D, Integer.MinValue) ' overflow | ||
| CheckDouble(Integer.MaxValue + 0.99D, ]]><%= If(ExecutionConditionUtil.IsMonoOrCoreClr, "Integer.MaxValue", "Integer.MinValue") %><![CDATA[) ' overflow | ||
| CheckDouble(Integer.MaxValue + 1D, ]]><%= If(ExecutionConditionUtil.IsMonoOrCoreClr, "Integer.MaxValue", "Integer.MinValue") %><![CDATA[) ' overflow | ||
| CheckDouble(Integer.MaxValue + 2D, ]]><%= If(ExecutionConditionUtil.IsMonoOrCoreClr, "Integer.MaxValue", "Integer.MinValue") %><
There was a problem hiding this comment.
Did you consider changing CheckDouble so that it has an overload that takes two arguments: expected framework and expected core? That may make the callsite code a bit cleaner.
There was a problem hiding this comment.
That could be done but at the price of having to do many more code changes - the CheckDouble/CheckSingle methods are defined in each test separately (so either we would have to change the tests to share them or update the method in each of these tests), I'm not sure that's worth it.
jaredpar
approved these changes
Sep 4, 2024
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #74026.